-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
int4: disable const_folding for unpack_int4 #3322
Conversation
c9ba87b
to
24419a6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3322 +/- ##
===========================================
- Coverage 92.04% 92.02% -0.02%
===========================================
Files 506 508 +2
Lines 20872 20948 +76
===========================================
+ Hits 19212 19278 +66
- Misses 1660 1670 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9c944af
to
8c3147d
Compare
8c3147d
to
d2d6bc0
Compare
@pfultz2, @CharlieL7, this PR is being moved out of the draft mode. Some of its necessary functionality is in other PRs. For example, block_quantization support. Also int4 (i.e. signed support) for the basic pack/unpack. Parse int4 graph. |
ca640d7
to
9774153
Compare
9774153
to
7c643e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still missing unit test for simplify_qdq. It really should be addressed either before merging or after merging.
Added. |
There is an mlir failure on jenkins:
Do you see this same error locally? |
No. |
If this needs a change from mlir to work, then just comment out the broken test for now so we can merge this in. |
Thanks. Actually, MLIR has a fix just commited-in. But I can disable the test. However, we do need one more approval :-) |
I've got #3467 which is pulling from mlir tip. I"m planning to merge it asap |
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
disable const_folding for unpack_int4